feat: Integrate AttributionId Flow - #112
Conversation
Code Coverage
|
|
One more note that could not be anchored to a diff line since
|
| implementation(libs.play.services.maps) | ||
| implementation(libs.startup.runtime) | ||
| testImplementation(libs.junit) | ||
| androidTestImplementation(libs.androidx.espresso.core) |
There was a problem hiding this comment.
androidTestImplementation(libs.androidx.espresso.core) and androidx.junit are declared here, but this module has no src/androidTest source set. These dependencies resolve and download for no benefit until an androidTest source set actually exists. Consider removing them until they're needed.
| gradleMavenPublishPlugin = "0.36.0" | ||
| mockk = "1.14.11" | ||
| startup-runtime = "1.2.0" | ||
| coreKtxVersion = "1.7.0" |
There was a problem hiding this comment.
coreKtxVersion (1.7.0, backing androidx.test:core-ktx) is easy to confuse with the pre-existing coreKtx (1.18.0, backing androidx.core:core-ktx) a few lines above. A future dependency bump could edit the wrong key by mistake. Consider a more distinct name, e.g. androidxTestCoreKtx.
Add androidx.startup:startup-runtime and a startup initializer to track sample repository usage. Uses androidx.startup.InitializationProvider for lightweight, automatic initialization on app startup.