Skip to content

feat: Integrate AttributionId Flow - #112

Merged
dkhawk merged 3 commits into
mainfrom
startup_runtime_integration
Aug 21, 2026
Merged

feat: Integrate AttributionId Flow#112
dkhawk merged 3 commits into
mainfrom
startup_runtime_integration

Conversation

@LoyalAbbas

Copy link
Copy Markdown
Contributor

Add androidx.startup:startup-runtime and a startup initializer to track sample repository usage. Uses androidx.startup.InitializationProvider for lightweight, automatic initialization on app startup.

@LoyalAbbas
LoyalAbbas requested review from dkhawk and kikoso and removed request for kikoso August 18, 2026 05:45
Comment thread places-compose/build.gradle.kts Fixed
Comment thread gradle/libs.versions.toml Fixed
Comment thread gradle/libs.versions.toml Fixed
Comment thread places-compose-demo/build.gradle.kts Fixed
Comment thread places-compose-demo/build.gradle.kts Fixed
@googlemaps-bot

Copy link
Copy Markdown
Contributor

Code Coverage

Overall Project 0%

There is no coverage information present for the Files changed

@kikoso kikoso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

@kikoso

kikoso commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

One more note that could not be anchored to a diff line since library/consumer-rules.keep is an empty new file:

library/consumer-rules.keep is created but never wired up. library/build.gradle.kts's defaultConfig block does not call consumerProguardFiles("consumer-rules.keep"), unlike places-compose/build.gradle.kts which does this for its own consumer-rules.pro. If keep rules are added here later, for example to protect the reflectively loaded AttributionIdInitializer (referenced by class name in AndroidManifest.xml for androidx.startup) from R8 stripping in minified consumer apps, they will silently have no effect. The nonstandard .keep extension, versus the project's established .pro convention, suggests this hookup was simply forgotten.

@kikoso kikoso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review notes

Comment thread library/build.gradle.kts Outdated
implementation(libs.play.services.maps)
implementation(libs.startup.runtime)
testImplementation(libs.junit)
androidTestImplementation(libs.androidx.espresso.core)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

androidTestImplementation(libs.androidx.espresso.core) and androidx.junit are declared here, but this module has no src/androidTest source set. These dependencies resolve and download for no benefit until an androidTest source set actually exists. Consider removing them until they're needed.

Comment thread gradle/libs.versions.toml Outdated
gradleMavenPublishPlugin = "0.36.0"
mockk = "1.14.11"
startup-runtime = "1.2.0"
coreKtxVersion = "1.7.0"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coreKtxVersion (1.7.0, backing androidx.test:core-ktx) is easy to confuse with the pre-existing coreKtx (1.18.0, backing androidx.core:core-ktx) a few lines above. A future dependency bump could edit the wrong key by mistake. Consider a more distinct name, e.g. androidxTestCoreKtx.

@kikoso kikoso left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhawk
dkhawk merged commit 38d1581 into main Aug 21, 2026
11 checks passed
@dkhawk
dkhawk deleted the startup_runtime_integration branch August 21, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants