encoder: skip unexported named fields - #254
Open
team-humaki wants to merge 1 commit into
Open
team-humaki wants to merge 1 commit into
team-humaki wants to merge 1 commit into
Conversation
Unexported named fields panicked on Decode (Set on values obtained from another package, including nil embedded pointers) and were included in Encode. Skip them, and do not Set when CanSet is false. Fixes gorilla#234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unexported named fields panicked on Decode when reflect.Value.Set ran on a value from another package, including a nil unexported embedded pointer. Encode also wrote those fields.
Skip unexported named fields on Encode. On Decode, do not Set when CanSet is false, and walk field indexes without panicking on a nil embed.
Fixes #234