Add 'postAppImageStep' to modify the app image before packaging - #136
Open
koppor wants to merge 1 commit into
Open
Add 'postAppImageStep' to modify the app image before packaging#136koppor wants to merge 1 commit into
koppor wants to merge 1 commit into
Conversation
Creating a JEP 514 AOT cache requires running the packaged launcher once and storing the result inside the app image, which has to happen after jpackage assembled the image but before the OS-specific packages are derived from it. The new option runs an Action on the app image directory at exactly that point; it is rejected together with 'singleStepPackaging', where no intermediate image exists. Closes gradlex-org#135 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JnKVoy56BKWZAkVtvSqNgg
✅ All tests passed ✅🏷️ Commit: 2492445 Learn more about TestLens at testlens.app/docs. |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Adds an optional
postAppImageStepper target: anAction<Directory>that receives the app image after all resources have been copied into it and runs before the OS-specific packages are built from it, so modifications land in every package instead of only in theapp-imageartifact. It is rejected together withsingleStepPackaging, where no intermediate app image exists, and is not a task input — documented in the README. My use case is training a JEP 514 AOT cache, but the hook is generic.Closes #135
Steps to test:
./gradlew quickCheck— the two new tests inJavaModulePackagingOptionsTestcover a hook writing a marker file into the packaged image (under--configuration-cache) and thesingleStepPackagingrejection.🤖 Generated with Claude Code
https://claude.ai/code/session_01JnKVoy56BKWZAkVtvSqNgg