Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadManyspawns a new goroutine per key, which may lead to excessive CPU and memory usage under heavy load.Since
LoadManyis just a wrapper aroundLoadcalls, andLoaditself is guarded by two global locks (batchLockandcacheLock), the goroutines don't seem to buy us anything here and, as far as I can tell, can be removed entirely with no functional drawbacks.In my PR I've refactored
LoadManyto get rid of those goroutines.I believe the change is backwards compatible, but there's one small detail worth mentioning:
LoadManyused to callthunk()itself, which is no longer the case — this makesLoadManylazy, just like Load already is. I'd expect this to be a minor change that shouldn't break anything, but please let me know if I'm missing a case here.