Repository navigation
fix: hide RPC keys in logs and keep late offer hashes - #736
Merged
Merged
Conversation
The latest-block cross-check logged each endpoint's raw error, which names its URL, and hosted endpoints carry their API key in the URL. It now logs the same redacted description other calls use.
An agreement can be marked for cancelling while its offer is mining, and the offer can still land. Its hash is now stored then, without moving the time that paces its cancel retry, and an ended agreement reports that nothing was stored instead of skipping silently.
Every warning passes through the Slack alert layer, which formatted all of a line's fields before checking its tag. It now reads the tag first and formats the rest only for listed events.
2 comments said the cancel path reads ConfigError as the chain client being switched off, which no code does any more.
MoonBoi9001
marked this pull request as ready for review
October 8, 2026 20:11
MoonBoi9001
added this pull request to stack #741
October 9, 2026 17:56
MoonBoi9001
removed this pull request from stack #741
October 9, 2026 17:58
MoonBoi9001
added this pull request to stack #742
October 9, 2026 17:58
MoonBoi9001
removed this pull request from stack #742
October 9, 2026 17:58
MoonBoi9001
added this pull request to stack #743
October 9, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest-block cross-check now logs endpoint failures without the URL, which carries the API key, and an offer that mines after its agreement was marked for cancelling keeps its hash. The Slack alert layer also stops formatting warnings it won't post, and 2 comments no longer claim a configuration error switches off cancelling.