Repository navigation
perf: record a replayed accept and cancel in 1 write - #739
Merged
Conversation
When the listener re-reads an agreement already ended that was accepted on-chain, it recorded the end, then the accept, then the end again: 3 writes, ordered so nothing saw the accept on its own. It now records both in 1 write, which nothing can see half-done, so the order no longer matters.
MoonBoi9001
marked this pull request as ready for review
October 9, 2026 16:01
MoonBoi9001
added this pull request to stack #741
October 9, 2026 17:57
MoonBoi9001
removed this pull request from stack #741
October 9, 2026 17:58
MoonBoi9001
added this pull request to stack #742
October 9, 2026 17:58
MoonBoi9001
removed this pull request from stack #742
October 9, 2026 17:58
MoonBoi9001
added this pull request to stack #743
October 9, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the chain listener re-reads an agreement dipper had already ended that the chain shows accepted and then cancelled, it now records the accept and the end in 1 database write instead of 3. A single write can't be seen half-done, so the careful order the 3 writes needed, to keep the terminated event from going out with only the accept recorded, is no longer needed.