Skip to content

fix: restore composed Storybook controls #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Zlodej43sm merged 1 commit into from
Oct 5, 2026
Merged

fix: restore composed Storybook controls #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions bin/storybook/smoke-test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ try {
await page.waitForURL((url) => url.searchParams.get('path') === '/docs/react-introduction-theme-tokens-usage--docs');

await page.goto(`${base}/?path=/docs/react-introduction-ai-integration-overview--docs`);
await docs().getByRole('heading', { name: 'AI Integration', exact: true }).waitFor();
await docs().getByText('AI Integration', { exact: true }).first().waitFor();

await page.goto(`${base}/?path=/docs/react-theme-tokens-colors--docs`);
await page.waitForURL((url) => url.searchParams.get('path') === '/docs/theme-tokens-colors--docs');
Expand All @@ -93,15 +93,23 @@ try {
.waitFor();

await page.goto(`${base}/?path=/docs/patterns-best-practices-cross-device-ux-notes--docs`);
await docs().getByRole('heading', { name: 'Cross-Device UX Notes', exact: true }).waitFor();
await docs().getByText('Cross-Device UX Notes', { exact: true }).first().waitFor();

// Composition must load the child's own native renderer, not a React wrapper.
await page.goto(`${base}/?path=/story/web-components_introduction-overview--overview`);
const nativeFrame = page.frameLocator('#storybook-ref-web-components');
await nativeFrame.getByRole('heading', { name: 'Using Web Components', exact: true }).waitFor();

await page.goto(`${base}/?path=/story/web-components_atoms-button--default`);
await page.goto(`${base}/?path=/story/web-components_atoms-button--default&panel=addon-controls`);
await nativeFrame.getByRole('button', { name: 'Button', exact: true }).waitFor();
await page.getByText('variant', { exact: true }).first().waitFor();
await page.getByRole('combobox', { name: 'variant', exact: true }).selectOption('secondary');
await page.waitForFunction(
() =>
document.querySelector('#storybook-ref-web-components')?.contentDocument?.querySelector('gd-button')?.variant ===
'secondary'
);
assert.equal(await nativeFrame.locator('gd-button').evaluate((element) => element.variant), 'secondary');
await page.goto(`${base}/?path=/docs/web-components_atoms-button--docs`);
await nativeFrame.getByRole('heading', { name: 'Button', exact: true }).first().waitFor();

Expand Down
Loading
Loading