Repository navigation
fix(rosettify-prompts): reject duplicate suite IDs - #362
Merged
isolomatov-gd merged 1 commit intoSep 29, 2026
Merged
Conversation
Signed-off-by: Shin <128954611+shin4141@users.noreply.github.com>
shin4141
marked this pull request as ready for review
September 29, 2026 03:19
isolomatov-gd
approved these changes
Sep 29, 2026
isolomatov-gd
left a comment
Contributor
There was a problem hiding this comment.
@shin4141 thank you. The duplicate-ID check sits at the right place, and both tests prove the rule. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #352.
Reject repeated
suites[].idvalues during config parsing, before benchmark runs. The change keeps variant IDs scoped to their suites and documents the uniqueness rule in the package README.Problem and expected behavior
Reports group runs by
(suiteId, variantId). The previous parser accepted two suites with the same ID. With the same variant ID in both, each summary included both suites' runs and the first sample reply appeared in both sections. Issue #352 explicitly asks for repeated suite IDs to be rejected before execution; it does not ask the report to invent another identity for them.Change
parseConfigand report the duplicated ID.src/rosettify-prompts/README.md.This is a three-file change with 28 added lines and no removed lines. Configs that previously used duplicate suite IDs must rename those suites before running again.
Validation and limits
cb0fe59ee4969fe222831e41a693cdf796e17e18,npm ciinstalled the package lockfile's Zod 3.25.76, Vitest 4.1.10, and TypeScript 5.9.3. With Node 26.4.0 and npm 11.17.0,npm testpassed all 98 tests in 9 files;npm run typecheckandnpm run buildpassed. The worktree remained clean after validation, and the commit's three-file diff matched the proposed patch exactly.src/validate-types.shpassed for the installed package. The repository's fullvenv/bin/python scripts/pre_commit.pyalso passed: hooks build, standard and lightweight plugin sync, Python type validation and tests, hooks tests (1,441 in 35 files), and rosettify-prompts tests (98 in 9 files). Its script skipped the unrelated curiocity, rosettify, and rosettify-plugins TypeScript checks/tests because theirnode_moduleswere not installed; this is not a claim of repository-wide coverage.npm ci, typecheck, build, and tests on Node 24; CodeQL Advanced succeeded.The initial sandboxed npm request could not resolve the registry. A host-side CLI with a temporary cache completed the lockfile install; npm warned that esbuild and fsevents lifecycle scripts were not approved in that environment, but the checks above passed. No Anthropic or other paid model API was called.
AI assistance
Codex assisted with the private investigation, patch, and validation. The submitter authorized the DCO sign-off using the same identity as prior Rosetta contributions and remains responsible for the final diff.