Repository navigation
Conversation
… stays comparable with the run that has it.
BigTava
force-pushed
the
gsye-158-gsy-e-roi-changes
branch
from
October 6, 2026 23:39
82f68b9 to
cefd429
Compare
…ulation and report it to the JSON export and gsy-web.
…shared PV, annual generation and the low and high range to the RoI results.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1927 +/- ##
==========================================
+ Coverage 73.08% 73.53% +0.44%
==========================================
Files 156 159 +3
Lines 15124 15388 +264
Branches 1934 1973 +39
==========================================
+ Hits 11053 11315 +262
+ Misses 3554 3550 -4
- Partials 517 523 +6 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoiResultsCollectorgives each PV a return-on-investment result using the D7.3 trade-based baseline. Energy that reaches a consumer in the PV's own area, directly or through a battery there, is valued at the supplier rate plus path grid fees, and energy sold outside the area is revenue.ownership_member_uuidsandownership_sharesand gets a community result plus one per member. An optionalannual_generation_kWhannualises a short run by season, and every result carries low and high cases over the four D7.3 range levers.aggregated_results/roi.jsonon CLI runs and addsroito the final payload sent to gsy-web.ORDER_BY_ITEM_HASHconstant keeps a run without one asset comparable with the run that has it, while normal runs keep the numpy ordering. This touches the same numpy calls as PR use python random instead numpy #1526, so the two will conflict.INTEGRATION_TESTS_BRANCH=master
GSY_FRAMEWORK_BRANCH=feature/GSYE-158-roi-engine
SCM_ENGINE_BRANCH=master