Skip to content

update description when update modification - #217

Open
EtienneLt wants to merge 6 commits into
mainfrom
extract-composite-to-share-description
Open

EtienneLt wants to merge 6 commits into
mainfrom
extract-composite-to-share-description

Conversation

@EtienneLt

Copy link
Copy Markdown
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 03c98d7d-67ce-4ebc-a57a-6f237168b0c7


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Mathieu-Deharbe
Mathieu-Deharbe self-requested a review September 24, 2026 09:01
);
if (newName != null) {
uriComponentsBuilder.queryParam(NAME, newName);
uriComponentsBuilder.queryParam(DESCRIPTION, newDescription);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is probably what caused this : gridsuite/study-server#1093 (review)

Comment on lines 33 to +34
public static final String NAME = "name";
public static final String DESCRIPTION = "description";

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit strange that those statics are defined here but also in ExploreController :
private static final String QUERY_PARAM_DESCRIPTION = "description";

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but maybe exploreController will be separated in several several controller soon

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants