tests are not strict enough

[jonenst]

webClient.get.expectBody(Toto.class) doesn't throw on missing fields, it just uses the default value of the bean, so for example for boolean values it defaults to false, which is our case was also the expected value.

This bug allowed a bug to slip in: the "private: false" field was missing entirely but the test still worked

[jonenst]

Actually the tests don't assert anything...

        webTestClient.get()
                .uri("/v1/studies")
                .header("userId", "userId")
                .exchange()
                .expectStatus().isOk()
                .expectHeader().contentType(MediaType.APPLICATION_JSON)
                .expectBodyList(StudyInfos.class)
                .value(studies -> new MatcherStudyInfos(StudyInfos.builder().studyName("studyName").userId("userId").caseFormat("UCTE")
                        .description("description").studyPrivate(false).creationDate(ZonedDateTime.now(ZoneId.of("UTC"))).loadFlowStatus(LoadFlowStatus.NOT_DONE)
                        .build()).matchesSafely(studies.get(0)));

You can change anything in the matcher, the test always passes..