feat(editor): author NPC actions in game - #14
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bec86cba0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| binding.conditions.isEmpty() && | ||
| binding.cooldownMillis == 0L && | ||
| binding.debounceMillis == 0L && | ||
| binding.actions.all { it is ApplicationAction } |
There was a problem hiding this comment.
When an NPC has an unconditional, untimed binding for this trigger containing an unknown action or catalog-invalid arguments, this predicate still classifies the binding as replaceable and silently deletes it. Other mutations deliberately preserve such actions as READ_ONLY_APPLICATION_ACTION, so setting a different valid action can unexpectedly discard data the editor cannot safely interpret; reject the edit or only replace bindings whose existing application actions are verified.
Useful? React with 👍 / 👎.
1 participant
Summary
/scene npc <id> action set <trigger> <action-key>for catalog-backed, parameterless application actionsVerification
./gradlew spotlessCheck check --console=plainThis intentionally does not add arbitrary commands, URLs, or generic action-argument authoring.