Make local auth opt-in for dev and expose yt-dlp dependency readiness on /health - #1749
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: groupthinking <154503486+groupthinking@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Ensure local auth is opt-in and expose video deps readiness
Make local auth opt-in for dev and expose yt-dlp dependency readiness on Sep 8, 2026
/health
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| api_key if api_key is not None else os.getenv("EVENTRELAY_API_KEY") | ||
| ) | ||
| is_production = _is_production_env() | ||
| explicit_open = os.getenv("ALLOW_UNAUTHENTICATED", "").strip().lower() in _TRUTHY |
Contributor
There was a problem hiding this comment.
Auth middleware fails OPEN in any non-production environment (including internet-reachable Vercel preview and staging where ENVIRONMENT is unset), exposing all protected endpoints — including DELETE /api/v1/cache — without authentication when EVENTRELAY_API_KEY is not set.
groupthinking
approved these changes
Sep 12, 2026
Contributor
🔍 PR Validation |
github-actions
Bot
added
documentation
groupthinking
marked this pull request as ready for review
September 12, 2026 08:07
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🔴 E2E Test Results: FAILURE DETECTED
Test Output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonical issue
Linked automatically by canonical-issue workflow.
Outcome
Local FastAPI+Next runs no longer hit auth-driven 503s by default when no API key is set, while production remains fail-closed.
/healthnow exposes concrete readiness signals for yt-dlp-related runtime dependencies.Scope
EVENTRELAY_API_KEYis unset, non-production defaults to open auth (open_dev); production still returns 503 on protected routes unless explicitly overridden./healthwith explicit dependency flags for import/runtime tool availability:yt_dlp_readyyoutube_transcript_api_readyyt_dlp_executable_readyffmpeg_readyffprobe_readyvideo_path_readypreserved/api/v1/healthExample payload shape:
{ "auth_mode": "open_dev", "video_deps": { "yt_dlp": true, "youtube_transcript_api": true, "yt_dlp_executable": true, "ffmpeg": true, "ffprobe": true }, "yt_dlp_executable_ready": true, "ffmpeg_ready": true, "ffprobe_ready": true, "video_path_ready": true }Risk
src/youtube_extension/backend/middleware/api_key_auth.pyandsrc/youtube_extension/main.py.Verification
List exact automated and manual checks, tied to the current head SHA.
Production evidence
Not applicable for this change set: this PR targets local-dev auth ergonomics and backend health introspection fields; no production behavior expansion beyond existing fail-closed policy.
Agent handoff