Revert "servlet: fix write when not ready in AsyncServletOutputStreamWriter#12867
Open
kannanjgithub wants to merge 1 commit into
Open
Revert "servlet: fix write when not ready in AsyncServletOutputStreamWriter#12867kannanjgithub wants to merge 1 commit into
kannanjgithub wants to merge 1 commit into
Conversation
…Writer (grpc#12790)" This reverts commit 243b79e.
sauravzg
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 243b79e. The approach taken of ensuring subsequent writes go through the container thread via onWritePossible() hasn't eliminated the need for catching the IllegalStateException (which you are catching and buffering the write if it happens). We have observed that the UndertowInteropTest now hangs instead of the earlier flaky failures due to uncaught exception. There has been another PR #12732 for the same issue that explicitly checks isReady.getAsBoolean() in addition to the cached state, that's probably most reliable, because you don't have to deal with callback scheduling and the state changing in the meantime. We would like to proceed with that PR and revert this one.
@mgustimz