Add exempt bucket to the AWS Terraform coverage report - #208
Merged
Conversation
Resources deliberately kept outside Terraform now carry managed-by=exempt. Count them separately rather than as unmanaged, and exclude them from the coverage ratio the same way untaggable resources are excluded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resources that are deliberately kept outside Terraform now carry
managed-by = exempt, applied by hand rather than by a provider. The coverage report had no notion of that value, so it bucketed them asunmanagedand additionally listed them under "Tagged with an unrecognised managed-by value".This adds
exemptas a fourth bucket, excluded from the coverage ratio for the same reasonuntaggableis: counting a resource Terraform is never meant to touch as unmanaged makes it a permanent false positive.Also documents the difference between the two exclusions, which is easy to miss —
untaggableis a fact about AWS, whileexemptis an assertion someone made by hand and nothing here verifies. That is called out in the README and added to the script's Blind spots output.Verified against a live sweep of
035866691871:All 8 land in the new bucket and the "unrecognised managed-by value" section no longer fires.
The tag is being applied under hackforla/devops-security#176.