Stop overriding GitHubStatusPush's default generators - #370
Merged
Conversation
The explicit `generators=[BuildStartEndStatusGenerator(...)]` here dropped buildbot's own default `BuildRequestGenerator`, which posts a "pending" GitHub status as soon as a build is queued. Without it, a builder has no status at all until a worker actually starts it, so PRs could look all-green while several buildbots hadn't begun -- and merges landed before the builders ever ran. The `context=` override was also identical to the library default. Removing both restores the queued-state status and trims config that no longer needs to exist. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generators=[BuildStartEndStatusGenerator(...)]onGitHubStatusPushsilently dropped buildbot's own defaultBuildRequestGenerator, which posts a "pending" status the moment a build is queued. Thecontext=override here was also identical to the library default.GitHubStatusPushuse its defaults, restoring the pending/queued status. Verified viabuildbot checkconfigthat the config still loads, and confirmed by readingbuildbot/reporters/github.pyandbuildbot/reporters/generators/{build,buildrequest}.pythat both generator classes hardcodemode='all'and that our explicitbuilders=filters were no-ops (they enumerated the exact same builder set as the default's unfiltered behavior).Test plan
uv run ruff check/ruff format --checkonmaster/master.cfgbuildbot checkconfig .againstmaster/master.cfgbuildbot/<builder>status immediately on push, before any worker claims the build🤖 Generated with Claude Code