Restrict MCP access keys by IP address - #5
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70cd325526
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Security impact
Restricted access keys are accepted only when the resolved remote address matches an allowed entry from the same address family. IPv4 ranges never match IPv6 clients, and IPv6 ranges never match IPv4 clients.
CIDR masks must use unsigned decimal notation and stay within the address-family limit. Authentication fails closed when a restricted key has an unknown remote address or invalid stored configuration. A missing or empty allowlist preserves unrestricted access.
Deployments behind a reverse proxy must ensure that untrusted clients cannot control forwarded-address headers or bypass the trusted proxy.
Console
The create and edit forms use a multiline textarea for allowed IP addresses. The access-key list distinguishes unrestricted keys from keys with configured IP restrictions.
Verified against a running Halo 2.26.0 Console at
/console/mcp: the textarea, per-line examples, unrestricted hint, and list status render correctly with no browser console errors.Testing
git diff --check./gradlew check