Display relative path to SQLite DB on JRuby - #446
Open
katafrakt wants to merge 2 commits into
Open
Conversation
katafrakt
commented
Sep 5, 2026
| pathname = Pathname.new(path).expand_path | ||
| path = pathname.relative_path_from(Dir.current).to_s if pathname.to_s.start_with?("#{Dir.current}/") | ||
| end | ||
| path = relativize_for_display(database_path) |
Contributor
Author
There was a problem hiding this comment.
Actually, do we even need it here? This relative vs absolute path is a concern only for SQLite, so probably the change should be only there.
Contributor
|
ℹ️ Optional job failed: Ruby jruby |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last minute change in #434 was incorrect. The database path was changed to relative in
database.rb, butsqlite.rboverrode it, displaying absolute path and causing 46 specs to fail unnecessarily. Also, I somehow sneaked inDir.currentcall, which does not exist - switching toDir.pwdinstead.