Repository navigation
Conversation
Collaborator
|
A couple of things, first, this would break the API contract, and second not all files need to be text files, there could be binary files uploads. I think the spec in the API is fair and clear, and when using the generated libraries the client should take care of cleaning up the temporary files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three storage GET endpoints (
getOneStorageMap,getOneStorageGeneralFile,getOneStorageSSLCrtListFile) useschema: type: filein their responses. This causes generated clients (e.g. Go/OpenAPI Generator) to create temporary files on disk for every response, which are never cleaned up.This changes the response schema to
type: stringfor these three endpoints. Request-side type: file parameters (uploads) are not changed.Fixes #138