Repository navigation
MINOR: runtime: add atomic map replacement - #141
Merged
Merged
Conversation
parseMapPayload could lose an entry when it crossed a chunk boundary, lose deferred data after repeated crossings, or repeat stale data when a chunk exactly matched the buffer size. Build chunks with one buffer and flush it before adding an entry that would exceed the limit. This preserves every entry in its original order while keeping the existing AddMapPayloadVersioned size behavior.
Add ReplaceMapPayload to prepare a new map version, clear it, add the desired entries in order, and commit only after every step succeeds. Require HAProxy 2.4 or newer instead of falling back to a non-atomic update. An empty entry list commits an empty map.
Collaborator
|
Looks good to me. Thank you. |
Contributor
Author
|
Thank you @mjuraga! I've opened haproxytech/dataplaneapi#422 as a follow-up to get this into Data Plane API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ReplaceMapPayloadto atomically replace all entries in a runtime map. Also fixes payload chunking that could drop or repeat entries across buffer boundaries.Details
AddMapPayloadVersionedbehavior, while ensuring its large-payload atomic path preserves every entry.