Repository navigation
MINOR: specification: add runtime map replacement operation - #142
Merged
Merged
Conversation
tkjaer
force-pushed
the
tkjaer-runtime-map-put-spec
branch
from
November 6, 2026 20:21
627fe97 to
b5feaf6
Compare
Add the missing OpenAPI 2 PUT operation for atomically replacing all entries in a runtime map. Regenerate the bundled specification used by the embedded specification endpoint and generated clients.
tkjaer
force-pushed
the
tkjaer-runtime-map-put-spec
branch
2 times, most recently
from
November 6, 2026 20:35
4123e41 to
ef7bc49
Compare
Only remove generated top-level Go files before regenerating models. Keep models/funcs because go-method-gen requires its overrides and helpers.
tkjaer
force-pushed
the
tkjaer-runtime-map-put-spec
branch
from
November 6, 2026 20:51
ef7bc49 to
d57b8c2
Compare
Contributor
Author
|
Quick note on the force-pushes: I restored the generated specification after confirming it was required and not the original CI failure. The actual failure was the model-generation job deleting the handwritten The later |
Collaborator
|
No worries, I missed this too in my review. |
Collaborator
|
Also I need to fix our github CI in this and dataplaneapi project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing OpenAPI 2 operation for atomically replacing all entries in a runtime map.
Sorry, I missed this parallel specification update in the earlier work. This regenerates the bundled specification so the embedded
/specificationendpoint and generated clients include the existing API operation.cc @mjuraga