fix: unhashable type c_ubyte in Systec exception mapping#2078
Open
fazalpsinfo-cmyk wants to merge 1 commit into
Open
fix: unhashable type c_ubyte in Systec exception mapping#2078fazalpsinfo-cmyk wants to merge 1 commit into
fazalpsinfo-cmyk wants to merge 1 commit into
Conversation
The result parameter in UcanException.__init__ can be a ctypes.c_ubyte object (from UcanWriteCanMsgEx), which is unhashable and cannot be used as a dict key. Use result.value to get the underlying int instead. Fixes hardbyte#2077
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The
resultparameter inUcanException.__init__can be actypes.c_ubyteobject (fromUcanWriteCanMsgExviacheck_result), which is unhashable and cannot be used as a dict key, causing:This swallows the actual error message and prevents troubleshooting.
Change
Use
result.valueto get the underlying integer value, which is hashable and matches theReturnCodeIntEnum keys in the error message mapping.Fixes #2077
Support my open source work: https://buymeacoffee.com/muhamedfazalps