fix(socketcand): refuse remote frames instead of sending them as normal ones - #2100
Open
swimmingbrain wants to merge 2 commits into
Open
fix(socketcand): refuse remote frames instead of sending them as normal ones#2100swimmingbrain wants to merge 2 commits into
swimmingbrain wants to merge 2 commits into
Conversation
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending a remote frame through the socketcand interface puts a normal empty frame on the bus. The protocol's send command is
< send id dlc [data]* >, so there is nowhere to put the remote request flag and it just gets dropped. The report in #2091 has the candump output next to what python-can printed.There is no way to express it, and socketcand does not forward received remote frames either, so rather than sending something other than what was asked for, the converter now raises
CanOperationError. I also added tests for the message to ascii direction, which had none.Closes #2091