Skip to content

Panic instead of warn when esbuild not found #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markovejnovic merged 2 commits into from
Jun 10, 2026
Merged

Panic instead of warn when esbuild not found #136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98c65f8
refactor: panic instead of warn when esbuild not found
Power-el-Tanke Jun 10, 2026
1a4fac4
Merge branch 'harmont-dev:main' into panic-if-esbuild-not-found
Power-el-Tanke Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions crates/hm-dsl-engine/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
)]

use std::env;
use std::fs;
use std::path::{Path, PathBuf};
use std::process::Command;

Expand All @@ -22,17 +21,10 @@ fn main() {
let esbuild = find_esbuild(&manifest_dir);

let Some(esbuild) = esbuild else {
eprintln!(
"cargo:warning=esbuild not found; writing stub bundles. \
Run `npm ci` in crates/hm-dsl-engine/harmont-ts/ for real bundles."
panic!(
"esbuild not found.\
Install it or run `npm ci` in crates/hm-dsl-engine/harmont-ts/ for generating js bundles before building the crate."
);
fs::write(out_dir.join("harmont-index.mjs"), "// stub\nexport {};").unwrap();
fs::write(
out_dir.join("harmont-toolchains.mjs"),
"// stub\nexport {};",
)
.unwrap();
return;
};

bundle(
Expand Down
Loading