SRE-901: Stop handing CI more Vault reach than it uses - #405
Conversation
PR SummaryLow Risk Overview Workflow-level Reviewed by Cursor Bugbot for commit f89fee4. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
Reduces the default GitHub Actions token scope for the housekeeping workflow to match the Renovate reusable workflow’s actual needs, limiting CI’s Vault exposure and repository write permissions.
Changes:
- Downgrades workflow
permissions.contentsfromwritetoread. - Removes
secrets: inheritfrom therenovatejob invoking the pinned reusable workflow.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Applies the CI Vault narrowing from hashintel/hash#9160 to this repo.
secrets: inheritdropped from therenovatejob. The pinned reusable workflow reads nosecrets.*— the Vault address comes fromvars.VAULT_ADDR, a repo variable, whichsecrets: inheritnever carried.contents: write→read. The reusable workflow declarescontents: readfor itself, so the Renovate job's token is already read-only in the current scheduled runs. The caller-sidewriteonly reached this workflow's ownvalidatejob, which checks out and runsjq/actionlint.Related links
hashWhat tests cover this?
actionlintv1.7.12 on the changed file: clean. Renovate is proven green undercontents: read, since that is already its effective permission today.