Skip to content

FE-1310: add banner to ds - #9163

Open
alex-e-leon wants to merge 7 commits into
mainfrom
FE-1310-add-banner-to-ds
Open

FE-1310: add banner to ds#9163
alex-e-leon wants to merge 7 commits into
mainfrom
FE-1310-add-banner-to-ds

Conversation

@alex-e-leon

Copy link
Copy Markdown
Contributor

🌟 What is the purpose of this PR?

Add Banner component

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Building Building Preview Aug 5, 2026 12:03pm
hashdotdesign-tokens Ready Ready Preview Aug 5, 2026 12:03pm
petrinaut Ready Ready Preview Aug 5, 2026 12:03pm

@cursor

cursor Bot commented Aug 5, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
New exported Banner is low risk; Chip variant renames are a breaking change for any caller still using fill, fillLight, or subtle, and the shared Tone expansion affects TypeScript at component boundaries.

Overview
Adds a new Banner component to @hashintel/ds-components (recipe, compound API with Title / Description / Actions / ActionButton, Ladle stories) and exports it from the package. Banners support tones (neutral, brand, error, caution, success), variants (solid, soft, outline), optional default/custom leading icons, dismiss, and container-query layout so actions wrap on narrow widths.

Shared Tone now includes caution and success; related components narrow which tones they accept (e.g. Button excludes caution/success; checkbox/radio/toggle/menu item tones adjusted). Icon gains diamondExclamation for error banners.

Chip variant names are renamed for consistency: filldefined, fillLightsoft, subtleghost (defaults and stories updated)—a breaking API change for Chip consumers.

Changeset: patch release for @hashintel/ds-components.

Reviewed by Cursor Bugbot for commit 97d57b7. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread libs/@hashintel/ds-components/src/components/Banner/banner.recipe.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ce7538f. Configure here.

Comment thread libs/@hashintel/ds-components/src/components/Banner/banner.recipe.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

1 participant