Seed Schema Commons types behind SEED_COMMONS_TYPES flag - #76
Merged
Conversation
Registers the eight Draft-status org.haverstack types from @haverstack/commons on startup when opted in, defaulting off since the package is Draft status and registering a type is not free (GET /types, every app's type cache). defineType() is idempotent by construction, so this is safe on every boot. Closes #59
…types-2178sy # Conflicts: # .env.example # README.md # src/config.ts # tests/setup.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@haverstack/commons(now published —haverstack/core#167is resolved) as a dependency and registers all eight Draft-statusorg.haverstack/*types viadefineCommonsTypes()ininitStack(), gated behind a newSEED_COMMONS_TYPESconfig flag, default off.defineType()is idempotent by construction, so seeding runs safely on every boot, same as the existing system-type seeding..env.example, theREADME.mdconfig table, and a newdocs/deployment.md#schema-commons-seedingsection explain why the flag defaults off while the package is Draft status.Test plan
pnpm typecheckpnpm lintpnpm format:checkpnpm test(331 passed, including 3 new cases intests/stack.test.ts: flag off → no commons types registered, flag on → all 8 registered, and a second boot with the flag on causes nocreatedAtchurn)Closes #59
Generated by Claude Code