Skip to content

defaultIsOpen feature does not work when combined with closeOnChangedValue  #718

Description

@BentleyDavis

Description the bug
defaultIsOpen feature does not work when combined with closeOnChangedValue

Sandbox / Git Repo
https://codesandbox.io/s/defaultisopen-and-closeonchangedvalue-q4mrsd

To Reproduce
Steps to reproduce the behavior:

  1. Set the option defaultIsOpen={true}
  2. Render and see it open automatically
  3. Set the options closeOnChangedValue={true}
  4. Render and see it no longer opens automatically

Expected behavior
The select should stay open until acted on. It opens then quickly shuts before the user can get to it.

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Brave
  • Version: v1.60.114

Smartphone (please complete the following information):
N/A

Additional context
Looks like in dropdown.tsx line 35 the useEffect closes the select on all renders including the first.

useEffect(() => {
    if (closeOnChangedValue) {
      setExpanded(false);
    }
  }, [value]);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions