Keep thread name after attaching it to JVM#1713
Merged
rustam-gamidov-here merged 1 commit intoJul 14, 2026
Merged
Conversation
mzimonczyk-here
force-pushed
the
mzimonczyk/jniThreadBinder
branch
from
38bcbb4 to
45c955c
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1713 +/- ##
==========================================
+ Coverage 80.30% 80.32% +0.02%
==========================================
Files 356 356
Lines 14285 14285
Branches 1564 1564
==========================================
+ Hits 11471 11474 +3
Misses 2182 2182
+ Partials 632 629 -3 🚀 New features to boost your workflow:
|
mzimonczyk-here
force-pushed
the
mzimonczyk/jniThreadBinder
branch
3 times, most recently
from
79c8680 to
515264f
Compare
andrey-kashcheev
previously approved these changes
Jul 14, 2026
andrey-kashcheev
requested review from
asopov-here,
khomenkd,
mykolamalik and
rustam-gamidov-here
rustam-gamidov-here
previously approved these changes
Jul 14, 2026
When native thread is attached to JVM, then it's name is taken from JavaVMAttachArgs. When no JavaVMAttachArgs, or no JavaVMAttachArgs::name passed, then JVM on its own decides on naming thread. Those names are not descriptive. To preserve thread name, pass the currently set thread name in JavaVMAttachArgs::name. Relates-To: HNAV-15387 Signed-off-by: Michal Zimonczyk <ext-michal.zimonczyk@here.com>
mzimonczyk-here
dismissed stale reviews from rustam-gamidov-here and andrey-kashcheev
via
e4ba33e
mzimonczyk-here
force-pushed
the
mzimonczyk/jniThreadBinder
branch
from
515264f to
e4ba33e
Compare
rustam-gamidov-here
approved these changes
Jul 14, 2026
mykolamalik
approved these changes
Jul 14, 2026
Collaborator
|
i assume @mzimonczyk-here is not able to merge as well as to trigger the pipelines, thus pressing the button for him |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When native thread is attached to JVM, then it's name is taken from JavaVMAttachArgs. When no JavaVMAttachArgs, or no JavaVMAttachArgs::name passed, then JVM on its own decides on naming thread. Those names are not descriptive. To preserve thread name, pass the currently set thread name in JavaVMAttachArgs::name.