Repository navigation
Re-enable the Poetry Python version mismatch test - #2150
Merged
Merged
Conversation
Poetry 2.5.0 fixed the upstream bug where Poetry didn't error on a Python version mismatch when `virtualenvs.create` is `false`: python-poetry/poetry#10226 python-poetry/poetry#10941 Now that the buildpack uses Poetry 2.5.1 (as of #2147), the disabled test can be re-enabled, and the outdated comment in `lib/poetry.sh` removed. GUS-W-24154059.
edmorley
marked this pull request as ready for review
October 1, 2026 22:10
edmorley
enabled auto-merge (squash)
October 1, 2026 22:10
runesoerensen
approved these changes
Oct 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Poetry 2.5.0 fixed the upstream bug where Poetry didn't error on a Python version mismatch when
virtualenvs.createisfalse:python-poetry/poetry#10226
python-poetry/poetry#10941
Now that the buildpack uses Poetry 2.5.1 (as of #2147), the disabled test can be re-enabled, and the outdated comment in
lib/poetry.shremoved.GUS-W-24154059.