Filter Bash read only config vars such as UID in export_env - #2152
Open
Hashim1999164 wants to merge 1 commit into
Open
Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
App config vars named like UID aborted the build when export_env tried to overwrite Bash read-only variables. Blacklist those names alongside the existing unsafe path related variables. Fixes heroku#1751
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1751
When an app sets a config var named like
UID,export_envtried to overwrite a Bash read only variable and the build aborted withUID: readonly variable.This adds the Bash read only names from the Bash Variables manual (
UID,EUID,PPID,BASHOPTS,BASHPID,BASH_VERSINFO,GROUPS,SHELLOPTS) to the default_env_blacklistused byexport_env/sub_env.Normal config vars still export as before.
Test plan
UIDandMY_APP_VARfiles;export_envsucceeds,MY_APP_VARis set,UIDis not overwritten