Repository navigation
Fix mobile test navigation overlap - #2363
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2363 +/- ##
=======================================
Coverage 97.02% 97.02%
=======================================
Files 130 130
Lines 5050 5050
=======================================
Hits 4900 4900
Misses 150 150 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2362.
When test results stack into one column on small screens, keep the verdict and test navigation in normal flow so scrolling to a selected test cannot hide its details underneath the navigation. Keep the sticky navigation in the desktop side-by-side layout.
Validation:
make test: 1,603 passed, 48 excluded.make test-fe: typecheck and production build passed.make lint-js,make credo(strict), andmake dialyzer: passed.Before/after mobile and desktop screenshots were captured during local browser verification.