Repository navigation
feat: дробные координаты точки - #10
Merged
Merged
Conversation
makePoint принимала только int, и задание php_compound_data_modeling с точкой (-1.5, 0) на PHP 8.5 печатало Deprecated: Implicit conversion from float to int loses precision, а координата теряла дробную часть. Копии библиотеки на JS, Python и Ruby дробные координаты принимают. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
makePoint() принимала только int. Задание php_compound_data_modeling строит точку (-1.5, 0), и на PHP 8.5 вызов печатал
Deprecated: Implicit conversion from float to int loses precision, а координата теряла дробную часть. Копии библиотеки на JS, Python и Ruby дробные координаты принимают.Типы makePoint(), getX() и getY() стали
int|float, getX() получил тип параметраarray. Тест проверяет точку с дробной координатой.Проверено в образе hexlet-php (PHP 8.5, PHPUnit 13): тесты зелёные, phpcs PSR12 чистый.
Практики берут библиотеку с
dev-main: ru и esphp_compound_data_modeling,points,abstractions.🤖 Generated with Claude Code