Repository navigation
Vendor hex_core v0.21.1 - #1285
Merged
Merged
Conversation
hex_core v0.21.1 skips a package file whose name resolves to the root of the tarball when it's a directory, instead of crashing with FunctionClauseError in :lists.seq/2 (hexpm/hex_core#252). Since hex_core v0.20.0 was vendored, mix hex.build crashed this way when the package files included the project directory, such as files: ["."], because expand_paths lists the directory itself as ".". Add a test that builds a package with files: ["."].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vendors hex_core v0.21.1 with
scripts/vendor_hex_core.sh.hex_core v0.21.1 skips a package file whose name resolves to the root of the tarball when it's a directory, instead of crashing with
FunctionClauseErrorin:lists.seq/2(hexpm/hex_core#252). Since hex_core v0.20.0 was vendored,mix hex.buildcrashed this way when the packagefilesincluded the project directory, such asfiles: ["."], becauseexpand_pathslists the directory itself as".". A new test builds a package withfiles: ["."].There's no changelog entry because no released Hex has the crash. The
mix_hex_tarball.erlin v2.5.4 doesn't have the code from hex_core v0.20.0 that crashes.