Repository navigation
fix: allow npm consumers to install without preinstall failure - #92
Merged
Merged
Conversation
Remove the published preinstall guard that blocked npm install when scratchpad is used as a dependency. Adopt LavaMoat's dev-only install protection via .yarnrc and @lavamoat/preinstall-always-fail instead. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: b679c1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preinstallscript that causednpm installto fail when@heymp/scratchpadis installed as a dependency (e.g.Do not run yarn install directly. Use: yarn setup)..yarnrcwithignore-scripts trueand@lavamoat/preinstall-always-failas a devDependency.yarn setup.Context
The
preinstallguard added in #84 runs for all installs of the published package, including when consumers runnpm installin their own projects. LavaMoat's documented pattern keeps install guards in devDependencies and repo-local config instead.Test plan
yarn setupyarn test(50 tests pass)npm install @heymp/scratchpad@nextsucceeds in a consumer projectMade with Cursor