Skip to content

refactor(cli): decompose render phases#2172

Merged
jrusso1020 merged 1 commit into
mainfrom
07-10-refactor-cli-decompose-render-phases
Jul 20, 2026
Merged

refactor(cli): decompose render phases#2172
jrusso1020 merged 1 commit into
mainfrom
07-10-refactor-cli-decompose-render-phases

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Decompose the CLI render command into explicit plan, execute, and present phases.

Why

The monolithic handler mixed validation, environment mutation, rendering, progress, cleanup, and output formatting, making lifecycle bugs and batch JSON corruption easy to introduce.

How

Build an immutable RenderPlan, keep environment changes declarative, execute through one lifecycle boundary, and make presentation emit exactly one final JSON document in batch mode.

Test plan

  • Render-plan and presentation tests; complete CLI suite
  • CLI build, typecheck, and stack-wide validation gates

This was referenced Jul 10, 2026

jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from ee1e8fd to 31ebbda Compare July 13, 2026 18:09
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 32efa63 to e4fa818 Compare July 13, 2026 18:35
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 3bd8775 to 841ca28 Compare July 13, 2026 20:27
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from e4fa818 to 119c3a7 Compare July 13, 2026 20:27
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 841ca28 to 99291ad Compare July 13, 2026 20:33
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 119c3a7 to 95c5ca5 Compare July 13, 2026 20:33
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 99291ad to 260558c Compare July 13, 2026 22:09
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 95c5ca5 to 138681f Compare July 13, 2026 22:09
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 260558c to f6dfed1 Compare July 13, 2026 22:18
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch 2 times, most recently from 15bbbc2 to f16b507 Compare July 13, 2026 23:08
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 50cf30c to a36d53c Compare July 14, 2026 00:03
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch 2 times, most recently from 57ef434 to a24f174 Compare July 14, 2026 03:20
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 3 times, most recently from ffda4eb to b84837b Compare July 14, 2026 17:11
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 53132dd to df7dfef Compare July 14, 2026 17:35
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from b84837b to 35ae1d2 Compare July 14, 2026 17:35
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from df7dfef to 608548d Compare July 14, 2026 17:57
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 35ae1d2 to 34981d4 Compare July 14, 2026 17:57
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 608548d to b3ce98b Compare July 14, 2026 18:06
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 34981d4 to 05b117e Compare July 14, 2026 18:06
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from b3ce98b to f593708 Compare July 14, 2026 19:37
@jrusso1020
jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from b418569 to 741b993 Compare July 14, 2026 19:42

@miguel-heygen miguel-heygen left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved exact head 3222f1f.\n\nAudited: the full 7-file diff, including the render transport adapter, plan/present/execute ownership split, batch JSON contract, compatibility re-exports, tests, all current issue comments/reviews/REST comments/GraphQL threads, and exact-head required CI.\n\nVerified the single and batch execution option payloads remain aligned with the prior handler; environment mutations are deferred without changing downstream reads; browser, lint, resolution, variables, and render dispatch ordering remains sound; Docker-only controls stay scoped; and the executable-boundary lifecycle contract remains intact. The strict quiet-lint refusal and exact integer validation are deliberate safety boundaries, not regressions. No blocking findings.\n\n— Magi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants