fix(producer): warn before huge CJK font subset downloads#2379
Closed
miguel-heygen wants to merge 1 commit into
Closed
fix(producer): warn before huge CJK font subset downloads#2379miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ).join("\n"); | ||
| const fetchImpl = (async (input: string | URL | Request) => { | ||
| const url = String(input); | ||
| return url.includes("fonts.googleapis.com") |
Collaborator
Author
|
Closing in the owner-scoped backlog value sweep. This is a narrow lint/audit/docs/example/skills refinement, is currently conflicting, or adds more maintenance surface than its demonstrated user impact justifies. Reopen only if a current reproducible case makes it a priority again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reproduction
The current Google Fonts request produces 1,116
@font-faceentries for Noto Sans JP and 45 for IBM Plex Mono, matching the 1,161-face feedback report.Test plan
bun test packages/producer/src/services/deterministicFonts-failClosed.test.ts(16 pass)