fix(check): clip overlap geometry to visible fragments - #3698
Open
miguel-heygen wants to merge 1 commit into
Open
fix(check): clip overlap geometry to visible fragments#3698miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
content_overlapno longer reports text that an overflow ancestor fully hides. Partially clipped text is measured by its painted area, so genuine visible collisions still cross the overlap threshold.Why
DOM Range rectangles remain geometrically present outside an overflow clip. Comparing those raw rectangles produced false-positive overlap warnings for translated or otherwise clipped text.
How
Text fragments are intersected with each overflow ancestor in viewport coordinates before overlap analysis. Clipping is axis-aware for
hidden,clip,auto, andscroll, whiledata-layout-allow-overlapremains a local opt-out.Test plan
Unit tests added/updated
Manual testing performed
Documentation updated (not applicable)
bunx vitest run src/commands/layout-audit.browser.test.ts --reporter=dot(89 tests passed)node --check packages/cli/src/commands/layout-audit.browser.jsbunx oxlint packages/cli/src/commands/layout-audit.browser.js packages/cli/src/commands/layout-audit.browser.test.tsbunx oxfmt --check packages/cli/src/commands/layout-audit.browser.js packages/cli/src/commands/layout-audit.browser.test.tsgit diff --checkThe package-wide typecheck is unavailable in this reused checkout because optional AWS, GCP, and producer dependencies are absent and existing cross-package type drift is present. It did not report errors in the changed browser audit or regression test.