fix(check): allow missing caption overrides - #3716
Merged
Merged
Conversation
miga-heygen
approved these changes
Sep 8, 2026
miga-heygen
left a comment
Contributor
There was a problem hiding this comment.
Reviewed: caption-overrides.json 404 correctly treated as silent no-op in both validate and checkBrowser. Payload validation added with proper error reporting. Tests cover missing sidecar, malformed JSON, non-array, and non-object entries. — Miga
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caption projects no longer fail
checkor deprecatedvalidatewhen the optional rootcaption-overrides.jsonis absent. Only that exact resource's 404 and benign aborted fetch are ignored; a 500, another missing JSON file, or a malformed present sidecar remains an error.The present-file contract is now explicit: the payload must be a JSON array whose entries are objects, and
[]is the valid explicit no-op. Invalid JSON, a non-array root, or a non-object entry emits a runtime error that browser validation records instead of being silently ignored.Related: #2263
Validation