Skip to content

fix(lint): recognize supported timeline registration forms - #3760

Open
Bortlesboat wants to merge 1 commit into
heygen-com:mainfrom
Bortlesboat:fix/lint-timeline-registration-forms
Open

fix(lint): recognize supported timeline registration forms#3760
Bortlesboat wants to merge 1 commit into
heygen-com:mainfrom
Bortlesboat:fix/lint-timeline-registration-forms

Conversation

@Bortlesboat

Copy link
Copy Markdown

What

Stop warning that a composition has no timeline when it registers one with window.__timelines.c1 = tl or window.__timelines = { c1: tl }. Commented registrations no longer suppress the warning.

Why

Those forms are already recognized by the core lint rule. The contradictory warning suggests adding data-no-timeline to a working composition.

How

Reuse the existing registration patterns after stripping comments. Keep the conservative bracket check for computed keys and logical assignments.

Test plan

  • Unit tests added/updated: all 615 lint tests pass with bun run --filter @hyperframes/lint test -- --reporter=dot --maxWorkers=4.
  • Manual testing performed: 12 checks against the built Node and browser entry points, executed in Node.
  • Documentation updated (not applicable).

Oxlint, oxfmt, the lint package typecheck, and both package builds pass. Earlier runs hit the existing stripJsStringLiterals scaling timing assertion; it also failed on unchanged e5d89f7. The final full run passed.

Post-Deploy Monitoring & Validation

No additional operational monitoring required; this changes static lint diagnostics only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant