Repository navigation
fix(cli): describe the restored skip-skills option - #6245
user-github-me wants to merge 2 commits into
Conversation
miguel-heygen
left a comment
There was a problem hiding this comment.
Thanks, this matches what the code does now. --skip-skills is read at init.ts:817 and skips keepSkillsCurrent on both the non-interactive and interactive paths, so "Skip installing missing core AI skills" is accurate, and the new example runs as written. The docs page and both skill references already describe the flag this way, so the help text now agrees with them.
One small leftover, optional here or in a follow-up: three CI step comments still say the flag is "neutered (see init.ts)": .github/workflows/ci.yml:1426 and :1490, and .github/workflows/windows-render.yml:250. Those steps pass both --skip-skills and HYPERFRAMES_SKIP_SKILLS=1, so nothing breaks, but the comments now contradict init.ts.
Reviewed at 50d7a1d. All checks are green.
Verdict: APPROVE
Reasoning: Help-text-only change that matches the flag's behavior on both init paths; checks are green and the only leftover is a stale comment elsewhere.
miguel-heygen
left a comment
There was a problem hiding this comment.
Thanks for updating the workflow comments. All three now match init.ts, and the env var is still worth keeping since it also turns off the background skills update check. Nothing else changed since my last review, and all checks are green.
Reviewed at a5511bd.
Verdict: APPROVE
Reasoning: The new commit only updates the three stale CI comments as suggested; the earlier approval holds and checks are green.
init --skip-skillsworks again after #6168, but its help still said it was temporarily ignored and three CI comments described it as neutered. Update the help description and example, retain the environment-variable alternative, and align the CI comments with the restored behavior.Refs #5025 for the stale-help follow-up identified by maintainers.
Validation: