[Feature request] - Upgrade react-native-vector-icons to v10

[liveafto]

Wondering if there is any chance to upgrade react-native-vector-icons to v10 version, the Ionicons names of md-add, md-remove, ios-arrow-up, ios-arrow-down of v10 version will be changed.

[joaolenosi]

any news?

[rares-nandra]

Sadly im pretty sure this repo is no longer mentained as i also raised 2 issues a few months ago. I am considering making a fork.

[Bryan47749]

This error occurs because the icons "md-remove" and "md-add" do not exist. To fix this, you should change the icon names to "remove" and "add".

[BlueRacoon]

npm uninstall react-native-numeric-input

npm install BlueRacoon/react-native-numeric-input

[rares-nandra]

@BlueRacoon
If you did the fork can you please also address some MAJOR bugs like the limit reached callback being inverted (isMax is true for the lower limit and vice versa for keyboard input only, for button input it works as intended) See pull request:
#95

And also the lack of a minus sign on iOS for inputing negative numbers (see: #97)

[dmi3y]

Thank you! @BlueRacoon

[BlueRacoon]

@BlueRacoon If you did the fork can you please also address some MAJOR bugs like the limit reached callback being inverted (isMax is true for the lower limit and vice versa for keyboard input only, for button input it works as intended) See pull request: #95

And also the lack of a minus sign on iOS for inputing negative numbers (see: #97)

Please see and review here :)
BlueRacoon@c9247a3
BlueRacoon@0eeb189

@rares-nandra

[rares-nandra]

@BlueRacoon you can commit the changes. Thank you!

[medonja]

@BlueRacoon hey, thanks for the fork! Could you also change the following:

in package.json:
"peerDependencies": {
"react-native-vector-icons": "^10.*"
}

in NumericInput.js, the ios-arrow-down and ios-arrow-up to arrow-down-outline and arrow-up-outline for the up-down type?

[DanSM-5]

I didn't fork the project but I've created a working version to avoid the dependency issue with react-native-vector-icons v10. Here are the files:

• NumericInput: https://github.com/DanSM-5/AddIt/tree/master/src/components/NumericInput
• pixelPerfect (dependency): https://github.com/DanSM-5/AddIt/blob/master/src/utils/pixelPerfect.ts (or you can install it from its source https://github.com/himelbrand/react-native-pixel-perfect)

I added two optional props increaseIconNameOverride and decreaseIconNameOverride to allow changing the icons as the previous names were no longer available. I used chevron-(forward|back|up|down)-circle as the default.

It should work if you want a drop-in replacement, just copy those files.

[khoatbd55]

@DanSM-5 thanks u so much