Remove plugin-added comment from secret-scanner rules - #11
Merged
Conversation
The migration tooling added an explanatory comment above the allowlist entries. It quoted a real internal value, and gitleaks scans comment text as content, so this file reported itself as a leak - failing the Secrets Scanner check on the commit that introduced it. The file now carries only what upstream ships plus the allowlist entries the migration guide requires. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
mashina-moj
approved these changes
Jul 29, 2026
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The migration tooling added an explanatory comment above the allowlist entries. It quoted a real internal value, and gitleaks scans comment text as content, so this file reported itself as a leak - failing the Secrets Scanner check on the commit that introduced it. The file now carries only what upstream ships plus the allowlist entries the migration guide requires.
Jira link
See PROJ-XXXXXX
Change description
Testing done
Security Vulnerability Assessment
CVE Suppression: Are there any CVEs present in the codebase (either newly introduced or pre-existing) that are being intentionally suppressed or ignored by this commit?
Checklist