Update Localized Strings - #5704
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
One updated zh-Hant settings search keyword string switches from comma separators to 、, but the app splits keywords on ,, breaking search matching for that entry.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates non-English Localizable.strings entries to add/refresh translations for recently added Settings/App Labs features (native tab bar, voice tools server, and tab bar customization), improving localized UX.
Changes:
- Added localized strings for the iOS native tab bar App Labs feature (title + footer) in zh-Hant / ko-KR / de.
- Added localized strings for Voice Tools Server settings (descriptions, statuses, permissions, etc.) in zh-Hant / ko-KR / de.
- Localized tab bar customization UI strings (Add/Remove/Tabs/More, etc.) in zh-Hant / ko-KR / de.
File summaries
| File | Description |
|---|---|
| Sources/App/Resources/zh-Hant.lproj/Localizable.strings | Adds Traditional Chinese translations for App Labs native tab bar, Voice Tools Server, and tab bar customization strings. |
| Sources/App/Resources/ko-KR.lproj/Localizable.strings | Adds Korean translations for App Labs native tab bar, Voice Tools Server, and tab bar customization strings. |
| Sources/App/Resources/de.lproj/Localizable.strings | Adds German translations for App Labs native tab bar, Voice Tools Server, and tab bar customization strings. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "settings.search_keywords.servers" = "連線、網址、帳號、實例、新增伺服器"; | ||
| "settings.search_keywords.siri" = "Siri、捷徑、spotlight、語音、助理"; | ||
| "settings.search_keywords.voice_tools_server" = "wyoming, speech, voice, assist, speech to text, text to speech, stt, tts, microphone, dictation"; | ||
| "settings.search_keywords.voice_tools_server" = "wyoming、語音、聲音、助理、語音轉文字、文字轉語音、STT、TTS、麥克風、聽寫"; |
| 伺服器僅在應用程式開啟時回應，離開後即停止運作。"; | ||
| "settings.voice_tools_server.footer" = "語音辨識與合成均在此裝置上進行。僅有文字及完成的音訊會透過區域網路傳輸。"; | ||
| "settings.voice_tools_server.languages.empty" = "此裝置沒有可用於裝置端語音辨識的語言。"; | ||
| "settings.voice_tools_server.languages.footer" = "此些語言的語音完全在此裝置上辨識。在設定App 中新增的聽寫語言，一旦支援裝置端辨識後便會顯示於此。"; |
Contributor
Author
|
Found 2 unused localization strings in the codebase. Click to see detailsTo remove them, run the |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5704 +/- ##
==========================================
+ Coverage 41.59% 41.62% +0.03%
==========================================
Files 1108 1108
Lines 77099 77099
==========================================
+ Hits 32066 32094 +28
+ Misses 45033 45005 -28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically created by zacwest.