Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid JSON Pointers through an empty root key currently resolve incorrectly. For example, a schema whose
valueproperty references#/should use the schema under the root's""key; instead a valid integer value can be rejected as an object.#//childalso drops the initial empty key.Two changes are needed for that consumer path:
#/otherwise sanitize to the same function name and overwrite one another. Ordinary non-colliding names remain unchanged.The 16 focused tests cover local and handler-loaded references through both
compile()andcompile_to_code(), empty keys, ordinary/root/array references, tilde and percent escapes, name collisions, and URI alias reuse. On the baseline, 15 fail and the ordinary-reference control passes.Validation:
pytest -m "not benchmark": 4,525 passed, 12 deselected, 449 xfailed, 936 non-strict xpassed. Unchanged baseline: 4,509 passed with the identical deselection/xfail/XPASS counts.git diff --checkpasses. Whole-project Pylint retains six identical baseline diagnostics in unrelated modules; it is separate from the required CI pytest command.This is a focused reference-resolution fix, not a claim of complete JSON Pointer conformance. No external schema network requests were made; handler coverage uses in-memory schema data. Hosted CI and other platforms remain pending.
AI assistance: Codex prepared the patch, tests, and description. A separate Codex agent reviewed the final resolver and generator call sites, independently ran all 16 focused tests, and executed the installed-wheel consumer. This is agent review, not human review.