Repository navigation
Escape null characters in generated pattern error messages - #226
Open
Doyoubelieveinfate wants to merge 1 commit into
Open
Doyoubelieveinfate wants to merge 1 commit into
Doyoubelieveinfate wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling a valid schema containing a literal NUL in
patternraisesSyntaxError: source code string cannot contain null bytes. This also affects character classes such as[\u0000-\u001f]and the source returned bycompile_to_code.Use the existing
CodeGenerator.e()helper to escape the pattern in the generated exception message. Regex compilation and matching are unchanged. The new tests cover both patterns, both compilation APIs and both detailed-exception settings, including the successful match and the rejected value's error message.Validation on macOS/Python 3.13.5:
pytest -W default --benchmark-skipwith the pinned JSON Schema Test Suite: 4,533 passed, 12 skipped, 445 xfailed and 940 xpassed; no failures.git diff --checkpasses.Prepared, tested and reviewed with Codex at the account owner's request.