Repository navigation
Preserve exact integer arithmetic for multipleOf - #229
Open
mayankdhingra02 wants to merge 1 commit into
Open
mayankdhingra02 wants to merge 1 commit into
mayankdhingra02 wants to merge 1 commit into
Conversation
Use integer remainders when both operands are integers. Floating-point quotients can round nonmultiples into integers or overflow on valid large multiples. Keep the existing float and Decimal paths unchanged. Test compiled and generated validators across supported schema drafts, including both error collection modes and unchanged noninteger operands. Signed-off-by: Mayank Dhingra <mayankdhingra02@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multipleOfcurrently accepts odd 64-bit integers such as2**63 - 1as multiples of 2 because true division rounds the quotient. It also raisesOverflowErrorfor valid large integer multiples such as3 * 10**400.Use an exact integer remainder when both operands are integers. Float and Decimal operands retain the existing handling. Regression tests exercise compiled and generated validators for drafts 04/06/07, both error collection modes, negative values, large divisors, zero and noninteger controls; 108 cases fail before the fix.
Validation:
git diff --checkpasses.