Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling a schema with
constanddetailed_exceptions=FalseraisesKeyError('definition_rule')before a validator is created. Read and escape the current rule value inside the compact exception branch and pass it to both compact exception paths. This avoids resolving references or traversing annotation data in that mode, while leaving the detailed exception branch unchanged. The regression tests cover draft-06/07, both exception modes, bothfast_failvalues, eight constant types, matching and nonmatching inputs, executablecompile_to_codeoutput, and annotation data containing an unresolved$ref.Reproducer (Python 3.10+):
Before:
After:
Validation on Python 3.12.13:
python -m pytest -m 'not benchmark'reports 4675 passed (4539 before), with the same 435 xfailed and 950 xpassed. The added regression cases fail 66 times on the original implementation.python -m pylint fastjsonschemareports the same nine existing diagnostics and 9.90/10 before and after.AI disclosure: Codex assisted with part of the code and this description.