parse_functions: find functions inside FROM-clause subqueries, joins and table-function arguments - #17
Open
asubbarao wants to merge 1 commit into
Conversation
asubbarao
requested review from
shefeek-jinnah
and removed request for
a team
September 24, 2026 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_function_namesandparse_functionsskip everything in the FROM clause: subqueries, both sides of a join, and table-function arguments, as well as scalar subqueries. The community build (parser_toolspinned at 6a94f2b) returns[]for the first query below.The traversal now descends into
from_table(join sides and conditions, subquery references, table-function arguments and subqueries) and intoSubqueryExpression, following the same table-reference patternparse_tablesuses.FROM (SELECT avg(n) …) s[][avg]FROM (SELECT upper(x) …) a JOIN (SELECT lower(y) …) b[][upper, lower]FROM range(abs(-5))[][abs]SELECT (SELECT sum(1)) WHERE x IN (SELECT length(z) …)[][sum, length]Verified against DuckDB v1.4.4 (this repo's pin): the four cases are added to both
parse_function_names.testandparse_functions.test. On the unpatched source both files fail ([] <> [avg], 2 of 11 test cases); with the patch all 11 test cases pass.🤖 Generated with Claude Code