docs: point the Hotdata CLI links at hotdata-cli; flag the HOTDATA_* env-var divergence - #94
Merged
Merged
Conversation
Both "Hotdata CLI" links (Requirements, Verify a load) pointed at hotdata-dev/sdk-python, which ships no console script — the hotdata CLI lives in hotdata-dev/hotdata-cli. The commands the README shows (databases list, databases tables list --database, query -d) are all hotdata-cli commands.
eddietejeda
requested review from
rohan-hotdata
and removed request for
a team
September 10, 2026 03:07
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Both "Hotdata CLI" links now point at hotdata-dev/hotdata-cli. The Resources list at README.md:516 still links the Python SDK separately, so the two references stay distinct. The HOTDATA_* env-var divergence described in the PR body is out of scope for this docs-only change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README accuracy audit against source at v0.16.0 (same flow as hotdata-dev/hotdata-ibis#55).
sdk-python, which ships no console script; the CLI lives inhotdata-cli. The three CLI commands shown were verified against hotdata-cli's clap definitions.Flagged, not fixed — needs a maintainer call: the Configuration table's env column lists plain
HOTDATA_*vars, but the destination never reads them — they're consumed only byconfig.py:from_env(), whose sole user is the diagnostic CLI, with defaults that disagree with the destination's. Verified empirically:HOTDATA_DATABASE_ID/HOTDATA_SCHEMA/HOTDATA_MAX_RETRIESdon't reach the resolved config;DESTINATION__HOTDATA__*forms do. OnlyHOTDATA_API_KEY(explicit bridge in factory.py) andDESTINATION__HOTDATA__MAX_STATE_FILESwork as documented. Since the changelog, runtime log, runbook, and .env.example all assert the plain-var contract, the likely fix is wiring them up in code rather than re-speccing the docs — so this PR reports it instead of rewriting the table.Everything else in the README verified against source.